Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hiding of axis lines and of images #7150

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix hiding of axis lines and of images #7150

merged 1 commit into from
Sep 16, 2024

Conversation

my-tien
Copy link
Contributor

@my-tien my-tien commented Sep 11, 2024

This should fix the failing baseline tests

@gvwilson gvwilson mentioned this pull request Sep 11, 2024
Open
@gvwilson gvwilson added P1 needs immediate attention fix fixes something broken community community contribution labels Sep 11, 2024
@gvwilson
Copy link
Contributor

is this instead of #7149 ?

@archmoj
Copy link
Contributor

archmoj commented Sep 11, 2024

is this instead of #7149 ?

No it's basically targeting #7149 branch instead of master branch.

@archmoj
Copy link
Contributor

archmoj commented Sep 12, 2024

Lot's of tests are failing.
Closing for now.
Thanks for the PR.

@archmoj archmoj closed this Sep 12, 2024
@archmoj archmoj reopened this Sep 16, 2024
@archmoj archmoj merged commit 73bac89 into plotly:fix7144-zorder-gridlines Sep 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@archmoj archmoj

Labels
community community contribution fix fixes something broken P1 needs immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@my-tien @gvwilson @archmoj