Merge pull request #7150 from my-tien/zorder-fix-axes-images

Fix hiding of axis lines and of images
plotly · Sep 16, 2024 · 73bac89 · 73bac89
2 parents c4f285e + cd6b1ae
commit 73bac89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/components/images/draw.js b/src/components/images/draw.js
@@ -5,6 +5,7 @@ var Drawing = require('../drawing');
 var Axes = require('../../plots/cartesian/axes');
 var axisIds = require('../../plots/cartesian/axis_ids');
 var xmlnsNamespaces = require('../../constants/xmlns_namespaces');
+var zindexSeparator = require('../../plots/cartesian/constants').zindexSeparator;
 
 module.exports = function draw(gd) {
     var fullLayout = gd._fullLayout;
@@ -226,6 +227,9 @@ module.exports = function draw(gd) {
     var allSubplots = Object.keys(fullLayout._plots);
     for(i = 0; i < allSubplots.length; i++) {
         subplot = allSubplots[i];
+        if (subplot.indexOf(zindexSeparator) !== -1) {
+            continue;
+        }
         var subplotObj = fullLayout._plots[subplot];
 
         // filter out overlaid plots (which have their images on the main plot)

diff --git a/src/plot_api/subroutines.js b/src/plot_api/subroutines.js
@@ -258,6 +258,9 @@ function lsInner(gd) {
     }
 
     for(subplot in fullLayout._plots) {
+        if (subplot.indexOf(zindexSeparator) !== -1) {
+            continue;
+        }
         plotinfo = fullLayout._plots[subplot];
         xa = plotinfo.xaxis;
         ya = plotinfo.yaxis;