Rewrite Linux syscalls generation #21440
Draft
+372
−803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes by Arnd Bergmann have migrated all supported architectures to use a table for their syscall lists. This removes the need of calling a C pre-processor and simplifies the logic dramatically.
The generic syscall table has different names for syscalls that take a timespec64 on 32-bit targets, in that it adds the `_time64` suffix. Similarly, the `_time32` suffix has been removed. I'm not sure if the existing logic for determining the proper timespec struct to use was subtly broken, but it should be a good chance to finish ziglang#4726 - we only have 14 years after all... In other news: - x86_64 gets `uretprobe`, a syscall to speed up returning BPF probes. - Hexagon gets `clone3`, but don't be fooled: it just returns ENOSYS.
This situation is highly confusing because |
alexrp
reviewed
Sep 18, 2024
| @@ -24,676 +24,240 @@ const stdlib_renames = std.StaticStringMap([]const u8).initComptime(.{ | |||
| .{ "arm_fadvise64_64", "fadvise64_64" }, | |||
There was a problem hiding this comment.
We should check if this list is still necessary, and if yes, whether all of the entries are.
|
Kinda scary that the CI passed 🙃 - do we not test for time overflow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes by Arnd Bergmann have migrated all supported architectures to use a table for their syscall lists. This removes the need of calling a C pre-processor and simplifies the logic dramatically.
The side effect is the number of names changed on targets that use the "generic" table. That list (located under
scripts/syscall.tbl) adds the_time64suffix to syscalls taking atimespec64on 32-bit targets. Similarly, the_time32suffix has been removed.The result is a lot of breakage in our Linux wrappers, which makes me worried that the logic for determining the proper
timespecto use was subtly broken all this time. Should be a good chance to finish #4726 - we only have 14 years after all...