std.posix: Added error message 'ProcessNotFound' for reading and writing in a Linux process #21430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process. This error occurs if the process to be read from or written to no longer exists. Fixes ziglang#19875
|
I can't complete this PR due to the complexity of the dependencies. Since I can't test on MacOS or Windows and the error message only says "test-fmt transitive error", I don't know how to fix this. |
|
It means you have code formatting violations; run |
ehaas
reviewed
Sep 16, 2024
lib/std/posix.zig
Outdated
| @@ -798,6 +798,10 @@ pub const ReadError = error{ | |||
| /// In WASI, this error occurs when the file descriptor does | |||
| /// not hold the required rights to read from it. | |||
| AccessDenied, | |||
|
|
|||
| // This error occurs in Linux if the process to be read from | |||
There was a problem hiding this comment.
These should be doc comments (/// instead of //)
alexrp
approved these changes
Sep 17, 2024
linusg
suggested changes
Sep 18, 2024
|
Because Linux returns the ENOENT error for a process (aka file) that no longer exists when trying to read or write to it. |
|
Then it would be good to note that in the original issue so the author knows they're mistaken or can clarify the situation in which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error occurs if the process to be read from or written to no longer exists.
Fixes #19875