Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HomePage logo image #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix HomePage logo image #192

wants to merge 1 commit into from

Conversation

networkdm
Copy link

  • Current issue:
    The HomePage.Logo component is not rendering the SVG image https://aptosfoundation.org/brandbook/logotype/SVG/Aptos_Primary_BLK.svg correctly and displays as zero width.

  • Proposed solution:
    This PR proposes adopting the approach used in the NavLogo component

    vocs/src/app/components/NavLogo.tsx

    Line 8 in deb697a

    if (config.logoUrl) return <Logo className={styles.logoImage} />
    which successfully renders the SVG logo.

@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vocs ❌ Failed (Inspect) Jul 26, 2024 4:45am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@networkdm