Merge pull request #1972 from dearchap/issue_1775

Fix:(issue_1775) Add test for zero value structs
urfave · Aug 26, 2024 · 3d76e1b · 3d76e1b
2 parents cd7d34a + e71eab6
commit 3d76e1b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/command_test.go b/command_test.go
@@ -3908,6 +3908,11 @@ func TestCommandReadArgsFromStdIn(t *testing.T) {
 	}
 }
 
+func TestZeroValueCommand(t *testing.T) {
+	var cmd Command
+	assert.NoError(t, cmd.Run(context.Background(), []string{"foo"}))
+}
+
 func TestJSONExportCommand(t *testing.T) {
 	cmd := buildExtendedTestCommand()
 	cmd.Arguments = []Argument{

diff --git a/flag_test.go b/flag_test.go
@@ -2997,3 +2997,8 @@ func TestStringMapFlagApply_Error(t *testing.T) {
 	err := set.Parse([]string{"--goat", "aaa", "bbb="})
 	assert.Error(t, err)
 }
+
+func TestZeroValueMutexFlag(t *testing.T) {
+	var fl MutuallyExclusiveFlags
+	assert.NoError(t, fl.check(&Command{}))
+}
diff --git a/value_source_test.go b/value_source_test.go
@@ -7,9 +7,18 @@ import (
 	"path/filepath"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
+func TestZeroValueSourceChain(t *testing.T) {
+	var vc ValueSourceChain
+	assert.Empty(t, vc.EnvKeys())
+	assert.NotEmpty(t, vc.GoString())
+	assert.Empty(t, vc.Chain)
+	assert.Empty(t, vc.String())
+}
+
 func TestEnvVarValueSource(t *testing.T) {
 	t.Run("implements ValueSource", func(t *testing.T) {
 		src := EnvVar("foo")