Do not expose the fields of the clients #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#26 is merged, this pr can be rebased |
|
I will do it after merging the mypy pr, as this depends on that as well |
We should keep the public API surface as minimal as possible. I don't see the benefit of making the configuration related fields of the client public. Hence, I converted all of them to protected fields. I have also updated the README in couple of places. I have removed the part where we mention you could have per-command-formatting configuration: It is a pretty bad idea to allow mutable state on the client object.
burak-upstash
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should keep the public API surface as minimal as possible.
I don't see the benefit of making the configuration related
fields of the client public. Hence, I converted all of them
to protected fields.
I have also updated the README in couple of places. I have removed
the part where we mention you could have per-command-formatting
configuration: It is a pretty bad idea to allow mutable state
on the client object.