Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update workflows #18

Merged
merged 4 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/pr-lint.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Lint PR
name: CI
on:
pull_request:
types: [opened, reopened, edited, synchronize]
Expand All @@ -14,14 +14,15 @@ jobs:
uses: actions/checkout@v3

- name: Setup pnpm
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v4
with:
version: 9
version: 9.6.0
run_install: false

- name: Setting up node v18.x
uses: actions/setup-node@v3
- name: Install Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: "pnpm"

- name: Install workspace dependencies
Expand Down
21 changes: 11 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test core selectors
name: Test

on:
push:
Expand All @@ -12,27 +12,28 @@ on:

jobs:
test:
name: Test scraping selectors
name: Main package
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout
uses: actions/checkout@v3

# setup pnpm to specific version to avoid breaking changes
- name: Setup pnpm
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v4
with:
version: 8
version: 9.6.0
run_install: false

- name: Setting up node v18.x
uses: actions/setup-node@v3
# action was tested on node 20.x
- name: Install Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --no-frozen-lockfile
run: pnpm install --frozen-lockfile

- name: Build Package using tsup and turbo
run: pnpm run build --filter=google-sr --filter=google-sr-selectors
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"node": ">=15.0.0",
"pnpm": ">=7"
},
"packageManager": "pnpm@8.6.12",
"packageManager": "pnpm@9.6.0",
"devDependencies": {
"@biomejs/biome": "1.8.3",
"@commitlint/cli": "19.3.0",
Expand Down
Loading