tracing-subscriber: refactor timings #3038
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This makes the
fmt::Subscriber
code a bit simpler, and preps theTiming
type for lifting elsewhere (e.g. to be made public and partof a timing layer instead of hidden within this Subscriber) (see
#2946)
Solution
This commit refactors the
Timings
struct to useDuration
instead ofu64
to store the idle and busy times of a span, and moves the logic toupdate the timings to the
Timings
struct itself. This commit alsointroduces a
display
method to theTimings
struct that returns theidle and busy times as
HumanReadableDuration
instances (renamed fromTimingDisplay
).Replaces: #2944