Abstract writer creation #3012
Open
Abstract writer creation #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everything over writer type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is second take on #2584 (first one was #2596).
This PR adds the feature of wrapping the default File writer with a user provided one. It is writer agnostic.
This change would allow (as shown in docs) to use
BufWriteror some compression on top of regular file, which is supper useful if you want to haveSolution
In contrast to the #2596, PR still uses
RwLockto store Writer and because of that requires users of library to implementWrite for &UserWriter.This PR changes API a bit (adds generics with default values and removes one
constconstructor).