-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: require the builder pattern for module initalisation #161
base: main
Are you sure you want to change the base?
refactor!: require the builder pattern for module initalisation #161
Conversation
e4e0a17
to
6045cb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use refactor
instead of chore
here
Thank you for the PR! ❤️
596faf7
to
ed7a50b
Compare
Sorry for that part. Forgot to do rustfmt after doing the (apparently missing doctests) testing run |
It's definitely not related to this PR and seems flaky - yes. For some reason, I think it happens only on Need to address this but in separate PR for sure |
…nt and encourages the builder pattern
ed7a50b
to
54c2d9f
Compare
This PR makes sure that the way structs are constructed is consistent and encourages the builder pattern.
It is based on this question: #156 (comment)
For the changelog:
We now require you to use the builder pattern (instead of some structs being unit structs) for all modules.
This ensures that if we add a field in the future that this will not break your existing code.
This change is breaking for these modules:
cncf_distribution::CncfDistribution
CncfDistribution.start()
CncfDistribution::default().start()
dynamodb_local::DynamoDb
DynamoDb.start()
DynamoDb::default().start()
elasticmq::ElasticMq
ElasticMq.start()
ElasticMq::default().start()
(see #143)mongo::Mongo
Mongo.start()
Mongo::default().start()
kwok::KwokCluster
KwokCluster.start()
KwokCluster::default().start()
rabbitmq::RabbitMq
RabbitMq.start()
RabbitMq::default().start()
redis::stack::RedisStack
RedisStack.start()
RedisStack::default().start()
redis::standalone::Redis
Redis.start()
Redis::default().start()
victoria_metrics::VictoriaMetrics
VictoriaMetrics.start()
VictoriaMetrics::default().start()