Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable crash reports entirely through macro #16794

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mymedia2
Copy link
Contributor

This saves compile time and binary size. Guarding code by preprocessor is the only effective way to guarantee its elimination, even in most modern C++. And more importantly, one do not need to care of it for porting to old Qt.

This saves compile time and binary size. Guarding code by preprocessor is the
only effective way to guarantee its elimination, even in most modern C++. And
more importantly, one do not need to care of it for porting to old Qt.
@ilya-fedin
Copy link
Contributor

Why are you doing that?

@mymedia2
Copy link
Contributor Author

@ilya-fedin I didn't ask you meaning of life

Copy link
Member

@john-preston john-preston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mymedia2 I don't like the idea of doing this using preprocessor. I think there should be core/not_started_window module, that contains code without preprocessor that is always built and core/crash_report_window module, that uses this core/not_started_window module. core/crash_report_window module should be excluded from the build in CMake using remove_target_sources in case of crash reports not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants