Editorial: Fix return-type of TemplateString[s] #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Jul 6, 2023
|
Can you add an assertion after step 4 of |
jmdyck
force-pushed
the
TemplateStrings_return
branch
from
195ae46
to
ba1abb9
Compare
michaelficarra
approved these changes
Jul 7, 2023
michaelficarra
added
the
ready to merge
|
Done. (I put the invariant in |
jmdyck
force-pushed
the
TemplateStrings_return
branch
from
ba1abb9
to
a329ff7
Compare
|
(force-pushed to squash down to one commit) |
In a tagged TemplateLiteral, NotEscapeSequence is allowed. The TV of `TemplateCharacter :: \ NotEscapeSequence` is `*undefined*`. This will then propagate up to TemplateString and TemplateStrings (when `_raw_` is `*false*`). This PR fixes the return-type of TemplateString[s] accordingly. It also adds a Note about return values in TemplateString, and an assertion in GetTemplateObject.
ljharb
force-pushed
the
TemplateStrings_return
branch
from
a329ff7
to
f3f2e25
Compare
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
In a tagged TemplateLiteral, NotEscapeSequence is allowed. The TV of `TemplateCharacter :: \ NotEscapeSequence` is `*undefined*`. This will then propagate up to TemplateString and TemplateStrings (when `_raw_` is `*false*`). This PR fixes the return-type of TemplateString[s] accordingly. It also adds a Note about return values in TemplateString, and an assertion in GetTemplateObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a tagged TemplateLiteral, NotEscapeSequence is allowed.
The TV of
TemplateCharacter :: \ NotEscapeSequenceis*undefined*.This will then propagate up to TemplateString and TemplateStrings (when
_raw_is*false*).This PR fixes the return-type of TemplateString[s] accordingly.