-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Make HasCallInTailPosition
for ImportCall
always return false
#3106
Normative: Make HasCallInTailPosition
for ImportCall
always return false
#3106
Conversation
|
Applying the chain rule would return function fn() {
return import(foo());
} |
Ah, so the problem is not that |
HasCallInTailPosition
for ImportCall
I edited the PR description. My original flow of thoughts was "why isn't this defined to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This should be landed as normative, but does not require plenary approval because it clearly fixes a bug so that it will match committee intent.
HasCallInTailPosition
for ImportCall
HasCallInTailPosition
for ImportCall
always return false
3470545
to
c88e81e
Compare
@ljharb I updated the PR title to be more descriptive, if you want to use it as the commit message |
c88e81e
to
53454a9
Compare
HasCallInTailPosition
is currently implicitly defined onImportCall
via the chain rule:HasCallInTailPosition
ofimport( xxx )
isHasCallInTailPosition
ofxxx
. This is wrong, becausexxx
is not in tail position.This PR explicitly defines it to be false.
For what is worth, JSC matches this PR (we can't talk about "web reality" in this case, it's just a spec bug):