Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable StrictConcurrency build setting #760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weissi
Copy link
Contributor

@weissi weissi commented Aug 7, 2024

Set

swiftSettings: [
    .enableExperimentalFeature("StrictConcurrency")
]

so we know where there's work.

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently incompatible with warnings-as-errors, so we need some CI tweaks to handle it.

@weissi
Copy link
Contributor Author

weissi commented Aug 7, 2024

This is currently incompatible with warnings-as-errors, so we need some CI tweaks to handle it.

Ah yeah, should I just tweak the CI?

@@ -32,7 +32,7 @@ services:

test:
<<: *common
command: /bin/bash -xcl "swift test --parallel -Xswiftc -warnings-as-errors --enable-test-discovery $${SANITIZER_ARG-} $${IMPORT_CHECK_ARG-}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lukasa removed that

@weissi weissi requested a review from Lukasa August 7, 2024 14:26
@Lukasa
Copy link
Collaborator

Lukasa commented Aug 7, 2024

That can work, though @FranzBusch is in the process of cutting over to a new CI scheme so we may want to hold off and tackle this slightly later.

It's also not clear that AHC can easily do this without us sorting out NIO first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants