Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Batch Offers #4

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

[Feature] Batch Offers #4

wants to merge 28 commits into from

Commits on Aug 13, 2024

  1. adds batchoffer example boilerplate

    @rymcol
    rymcol committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3ea2e13 View commit details
    Browse the repository at this point in the history

  2. updates to batchoffer

    @rymcol
    rymcol committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    bf5101a View commit details
    Browse the repository at this point in the history

  3. handles imports

    @rymcol
    rymcol committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3fb2fc8 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. handles remapping

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3762402 View commit details
    Browse the repository at this point in the history

  2. updates remapping

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2a379dd View commit details
    Browse the repository at this point in the history

  3. forge install: governance-contracts

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d3461b4 View commit details
    Browse the repository at this point in the history

  4. moves structs for batch offers to interface

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    17b208e View commit details
    Browse the repository at this point in the history

  5. add requirements to batch offer 

    ensures currency is approved and that offer is not expired
    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a0c28c7 View commit details
    Browse the repository at this point in the history

  6. fixes events

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    60d8f18 View commit details
    Browse the repository at this point in the history

  7. merge main

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a604275 View commit details
    Browse the repository at this point in the history

  8. reorder mark as sold

    @rymcol
    rymcol committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    45ce0e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. test: add tests 

    naming, tools, starts test
    @rymcol
    rymcol committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b3aa059 View commit details
    Browse the repository at this point in the history

  2. test: add failing test 

    successfully adds an offer, but reverts
    @rymcol
    rymcol committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    468824b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. test: improves failing tests

    @rymcol
    rymcol committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e95474f View commit details
    Browse the repository at this point in the history

  2. test: improves failing tests

    @rymcol
    rymcol committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    903fac6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. test: improves failing tests

    @rymcol
    rymcol committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    028787b View commit details
    Browse the repository at this point in the history

  2. test: fixes missing escrow

    @rymcol
    rymcol committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1413819 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. test: converts to single roundtrip test 

    much easier to prank than create/receive as separate tests
    @rymcol
    rymcol committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fbd2c9b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. refactors memory usage 

    make sure memory is cleaned up before transfers + uses currency from memory in offers rather than an input variable
    @rymcol
    rymcol committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    979d012 View commit details
    Browse the repository at this point in the history

  2. refactors offer storage 

    creates a new storage mapping of creator -> root hash -> offer to prevent DoS style attacks from using the same merkle root to block offers
    @rymcol
    rymcol committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    da23b21 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. update ABIs

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    72d4ceb View commit details
    Browse the repository at this point in the history

  2. add splits check to accept offer

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c47dd5d View commit details
    Browse the repository at this point in the history

  3. adds init address checks

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3686be2 View commit details
    Browse the repository at this point in the history

  4. ensure roothash is not empty

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d857556 View commit details
    Browse the repository at this point in the history

  5. optimize mload for gas

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    11485ec View commit details
    Browse the repository at this point in the history

  6. remove redundant root hash check 

    included in mapping and will not find offer if 0
    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d20b368 View commit details
    Browse the repository at this point in the history

  7. double check token owner before mark as sold

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6108a09 View commit details
    Browse the repository at this point in the history

  8. cleans bad linting

    @rymcol
    rymcol committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    70c93bd View commit details
    Browse the repository at this point in the history