[swift] Expose a few helper methods from SwiftGenerator #3115
Conversation
| @@ -6,7 +6,7 @@ public struct SwiftEdgeCases { | |||
|
|
|||
| @ProtoDefaulted | |||
| public var `return`: String? | |||
| public var error: SwiftEdgeCases.Error? | |||
| public var error: SwiftEdgeCases.Error_? | |||
There was a problem hiding this comment.
@lickel the fact that I consolidated this under a single helper method it now affected enums just like it did messages, does it look good to you as a change?
There was a problem hiding this comment.
it also looks like enums called Type are also emitted Type_ so this looks more aligned now
dnkoutso
force-pushed
the
expose_public_swift_helpers
branch
from
50a922e
to
307befc
Compare
| public final fun getSchema ()Lcom/squareup/wire/schema/Schema; | ||
| } | ||
|
|
||
| public final class com/squareup/wire/swift/SwiftGenerator$Companion { | ||
| public final fun builtInType (Lcom/squareup/wire/schema/ProtoType;)Z | ||
| public final fun get (Lcom/squareup/wire/schema/Schema;Ljava/util/Map;)Lcom/squareup/wire/swift/SwiftGenerator; | ||
| public static synthetic fun get$default (Lcom/squareup/wire/swift/SwiftGenerator$Companion;Lcom/squareup/wire/schema/Schema;Ljava/util/Map;ILjava/lang/Object;)Lcom/squareup/wire/swift/SwiftGenerator; | ||
| public final fun getBUILT_IN_TYPES ()Ljava/util/Map; |
There was a problem hiding this comment.
I am structurally OK with this, but you should have someone like @oldergod sign off on this change since it's an expansion of the public API.
Also: I suspect there's "better" ways to expose the constants, so it's not getBUILT_IN_TYPES() in Java-land
- Sign off from a maintainer
There was a problem hiding this comment.
I spoke to @oldergod offline about this to lead up to this PR but yes will wait for the approval here.
There was a problem hiding this comment.
@oldergod can we specify the name to expose for this tool so its not so ugly getBUILT_IN_TYPES?
These can be useful for custom schema handlers related to Swift.