Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add just command for releasing goose #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zakiali
Copy link
Collaborator

@zakiali zakiali commented Sep 9, 2024

Add just commands for creating a release PR (also updates ai-exchange package to latest), tagging, and pushing tags.

@zakiali zakiali force-pushed the zaki/justfile-update branch 2 times, most recently from 163eae3 to 7445677 Compare September 10, 2024 06:45
justfile Outdated
release version:
uvx --from=toml-cli toml set --toml-path=pyproject.toml project.version {{version}}
ai_exchange_version=$(just ai-exchange-version) && sed -i '' 's/ai-exchange>=.*/ai-exchange>='"${ai_exchange_version}"'\",/' pyproject.toml
git co -b release-version-{{version}}
Copy link
Contributor

@lamchau lamchau Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the full git checkout command since this would break for anyone who doesn't have git co as an alias for checkout (or is mapped to something differently altogether)

Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

justfile Outdated
uvx --from=toml-cli toml set --toml-path=pyproject.toml project.version {{version}}
ai_exchange_version=$(just ai-exchange-version) && sed -i '' 's/ai-exchange>=.*/ai-exchange>='"${ai_exchange_version}"'\",/' pyproject.toml
git co -b release-version-{{version}}
git add .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to be more specific here - too easy to have this accidentally commit something unintended. Just pyproject.toml should be enough?

@zakiali zakiali force-pushed the zaki/justfile-update branch 2 times, most recently from fcf5957 to 2b3ef77 Compare September 20, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants