Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelineTriggers): change buildNumber type from int to string #1213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaredstehler
Copy link

in order to support build numbers which are not strict integers (i.e. "123.1")

spinnaker/spinnaker#6743

@dbyron-sf
Copy link
Contributor

LGTM, but would like to make sure the orca and igor PRs ready and have them go in "at the same time."

@@ -64,7 +64,7 @@ trait RetrofitStubs {
}

BuildEvent createBuildEventWith(BuildEvent.Result result) {
def build = result ? new BuildEvent.Build(result == BUILDING, 1, result, null, []) : null
def build = result ? new BuildEvent.Build(result == BUILDING, '1', result, null, []) : null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER minor, but what about adding a test for a non-numeric build number as well as a numeric build number? :P And maybe a call out/comment on why? I like this overall though!

in order to support build numbers which are not strict integers (i.e. "123.1")
@jaredstehler
Copy link
Author

can this be merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants