-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse IdentityEntries into MonitoredIdentities #458
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: linus-sun <[email protected]>
…r structured output Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 64.02% 56.19% -7.84%
==========================================
Files 4 9 +5
Lines 303 694 +391
==========================================
+ Hits 194 390 +196
- Misses 78 239 +161
- Partials 31 65 +34 ☔ View full report in Codecov by Sentry. |
Signed-off-by: linus-sun <[email protected]>
3b9615b
to
9bc96c2
Compare
@@ -87,14 +87,26 @@ type MonitoredValues struct { | |||
|
|||
// IdentityEntry holds a certificate subject, issuer, OID extension and associated value, and log entry metadata | |||
type IdentityEntry struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also open to a refactoring of IdentityEntry into pkg/identity
, which would move this code into there as well- more broadly, what should the specifications be determining if code should go in pkg/rekor/identity
vs pkg/identity
?
Signed-off-by: linus-sun <[email protected]>
b88f627
to
311c533
Compare
Signed-off-by: linus-sun <[email protected]>
311c533
to
432d364
Compare
Summary
Per specification here, this PR implements the following:
Release Note
NONE
Documentation
none needed for this PR, changes to documentation will be made in future respective PRs which implement API changes