Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the install endpoint #291

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ngvtuan
Copy link

@ngvtuan ngvtuan commented Jan 24, 2022

fix the install endpoint

* master:
  bug: better errors (shuttle-hq#250)
  feat: add warnings for incompatible integer types with Postgres
  feat: postgres arrays
  docs: update example to use `date_time` type instead of `string` (shuttle-hq#258)
  feat: add some missing tools to the dev environment
  chore: bump synth 0.6.4
  test: complete tests for all postgres supported types
  refactor: refactor e2e testing
  refactor: remove unwrap() from Config::save() and truncate config file on save
  chore: bump synth 0.6.3
@christos-h
Copy link
Member

christos-h commented Jan 31, 2022

Hi @ngvtuan - thanks for this! Would it be possible split the PR into two parts?

  1. formatting change + prettier + editorconfig.
  2. functional changes to the install endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants