Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Website and docusaurus telemetry: cookie consent #289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ngvtuan
Copy link

@ngvtuan ngvtuan commented Jan 20, 2022

No description provided.

@ngvtuan ngvtuan changed the title Website and docusaurus telemetry: cookie consent feat: Website and docusaurus telemetry: cookie consent Jan 24, 2022
Copy link
Member

@christos-h christos-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Also tested it locally and everything works with flying colors. Like the other PR - could we split it into functional changes and formatting changes in separate PRs please?

docs/package.json Outdated Show resolved Hide resolved
docs/src/lib/helpers.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants