scripts/perftune.py: improve a dry-run printout #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's be optimistic when printing our intention during --dry-run execution: let's print the IRQ affinity configuration intent as if the Rx channels setting was successful. Without this patch we are going to print a different configuration intent than what we are actually going to configure. Note: unfortunatelly the same trick is not possible for RPS/XPS configuration intent because different NIC drivers are going to behave differently in regards to rps_cpus and xps_cpus files when one changes the numeber of Rx channels.
|
CI failures don't seem to be related to the patch itself. cc @xemul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's be optimistic when printing our intention during --dry-run execution: let's print the IRQ affinity configuration intent as if the Rx channels setting was successful.
Without this patch we are going to print a different configuration intent than what we are actually going to configure.
Note: unfortunatelly the same trick is not possible for RPS/XPS configuration intent because different NIC drivers are going to behave differently in regards to rps_cpus and xps_cpus files when one changes the numeber of Rx channels.