build: Add options to select sanitizers in configure.py #2437
+45
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to add ThreadSanitizer that can't be used together with AddressSanitizer. We want to choose which sanitizers to use. There are options to use sanitizers: Use ASAN and UBSAN for Debug and Sanitize build types: ./configure.py Use specified sanitizers for Debug and Sanitize build types: ./configure.py --sanitizer address --sanitizer undefined Do not use sanitizers for any build type: ./configure.py --no-sanitizers Enabling santizers is consistently with Seastar_SANITIZE option. Specified sanitizers are passed to Seastar_SANITIZERS list. If it is empty and Seastar_SANITIZE option is enabled for this build, the content of Seastar_DEFAULT_SANITIZERS will be used.
|
@tchaikov please review |
tchaikov
reviewed
Sep 17, 2024
| DEFAULT_BUILD_TYPES "Debug" "Sanitize" | ||
| CONDITION sanitizers_enabled) | ||
|
|
||
| if (sanitizers_enabled) |
There was a problem hiding this comment.
this does not work when we build seastar with a multi-config generator. in that case, the value of sanitizers_enabled would be a generator expression, which always evaluates to TRUE. and its value is supposed to be used like:
target_link_libraries (seastar
PUBLIC
$<${condition}:Sanitizers::address>)|
|
||
| if (sanitizers_enabled) | ||
| if ((NOT Seastar_SANITIZERS) OR (Seastar_SANITIZERS STREQUAL "")) | ||
| set (Seastar_SANITIZERS ${Seastar_DEFAULT_SANITIZERS}) |
There was a problem hiding this comment.
i'd suggest making Seastar_SANITIZERS a CMake option explicitly, like:
set (Seastar_SANITIZERS
"address;undefined_behavior"
CACHE
STRING
"Sanitizers enabled when building Seastar")and if we build with multi-config generator, this option applies to Debug and Sanitize modes, otherwise, this option applies the the current build.
what do you think?
| @@ -171,15 +173,23 @@ def identify_best_standard(cpp_standards, compiler): | |||
|
|
|||
| MODE_TO_CMAKE_BUILD_TYPE = {'release': 'RelWithDebInfo', 'debug': 'Debug', 'dev': 'Dev', 'sanitize': 'Sanitize' } | |||
|
|
|||
| SANITIZER_TO_CMAKE = {'address': 'address', 'undefined': 'undefined_behavior'} | |||
There was a problem hiding this comment.
why not just use undefined_behavior? what's the merit of introducing another layer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to add ThreadSanitizer that can't be used together with AddressSanitizer. We want to choose which sanitizers to use.
There are options to use sanitizers:
Use ASAN and UBSAN for Debug and Sanitize build types:
Use specified sanitizers for Debug and Sanitize build types:
Do not use sanitizers for any build type:
Specified sanitizers are passed to
Seastar_SANITIZERSlist. If it is empty andSeastar_SANITIZEoption is enabled for this build, the content ofSeastar_DEFAULT_SANITIZERSwill be used.