build: drop the workaround for a GCC bug #2430
Open
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change partially reverts 87a6540, which workarounded a bug in GCC-10 and LLVM-3.8, see https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=1842a04ce06a470b731bc9a29bfec17e6e147c3f and llvm/llvm-project@894d582 respectively. since scylla builds with GCC-13 and GCC-14, LLVM-17 and LLVM-18. so we don't need to keep this workaround anymore. Signed-off-by: Kefu Chai <[email protected]>
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change partially reverts 87a6540, which workarounded a bug in GCC-10 and LLVM-3.8, see
https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=1842a04ce06a470b731bc9a29bfec17e6e147c3f and
llvm/llvm-project@894d582 respectively.
since scylla builds with GCC-13 and GCC-14, LLVM-17 and LLVM-18. so we don't need to keep this workaround anymore.