Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stega options in loadQuery #1208

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

SimeonGriggs
Copy link
Contributor

@SimeonGriggs SimeonGriggs commented Apr 1, 2024

Currently when passing staga config into options it doesn't actually get used by loadQuery.

This has not been tested. I'm specifically unsure if the JSON.stringified version actually works...

@SimeonGriggs SimeonGriggs requested a review from a team as a code owner April 1, 2024 05:53
Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visual-editing-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-next-no-cache ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-next-server-only ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-next-with-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-page-builder-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am
visual-editing-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:18am

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stega to apply properly it needs to be extracted here:

const { query, params = {}, perspective, useCdn } = JSON.parse(key)

And passed in here:

const { result, resultSourceMap } = await client.fetch(query, params, {
tag,
filterResponse: false,
perspective,
useCdn,
})

@dnlmzw
Copy link

dnlmzw commented Sep 11, 2024

@SimeonGriggs Are there any plans to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants