-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sanity): refine error UI #7520
Open
juice49
wants to merge
5
commits into
next
Choose a base branch
from
feat/corel-172/refine-errory-boundary-ui
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
juice49
force-pushed
the
feat/corel-172/refine-errory-boundary-ui
branch
from
September 18, 2024 14:20
02dca51
to
aad64c8
Compare
No changes to documentation |
Component Testing Report Updated Sep 19, 2024 10:35 AM (UTC) ✅ All Tests Passed -- expand for details
|
juice49
force-pushed
the
feat/corel-172/refine-errory-boundary-ui
branch
from
September 19, 2024 09:09
5b7c332
to
411f74f
Compare
juice49
force-pushed
the
feat/corel-172/refine-errory-boundary-ui
branch
from
September 19, 2024 10:20
0a47197
to
2fb106d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch introduces UI refinements to the
StudioErrorBoundary
component. The aim is to make this error UI less intimidating for users.Additionally, the "Copy error details" action has been added to the document list error UI.
Global error
Before
After (production build)
After (development build)
Document list error
Before
After
What to review
StudioErrorBoundary
is rendered outside ofLocaleProvider
, and therefore the text cannot be internationalised. Is that okay?ErrorActions
(which is now used inside document lists), cannot be internationalised (the retry button in document lists was previously internationalised). Is that okay?Testing
Notes for release