Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Test exposed RufflePlayer API #17873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evilpie
Copy link
Collaborator

@evilpie evilpie commented Sep 12, 2024

This test ensures we notice when accidentally adding or removing something from the public RufflePlayer API.

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Sep 12, 2024

displayMessage was made public once more so that should be tested here too. We should avoid adding anything else if possible until .ruffle() exists though.

@evilpie evilpie added A-tests Area: Tests & Test Framework A-web Area: Web & Extensions waiting-on-review Waiting on review from a Ruffle team member labels Sep 13, 2024
@danielhjacobs danielhjacobs added the T-chore Type: Chore (like updating a dependency, it's gotta be done) label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: Tests & Test Framework A-web Area: Web & Extensions T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants