Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Berlin Buzzwords and FOSS Backstage #170

Open
wants to merge 137 commits into
base: master
Choose a base branch
from

Conversation

tthePB
Copy link

@tthePB tthePB commented Feb 26, 2018

No description provided.

roidrage and others added 30 commits April 20, 2016 16:55
Add Berlin Node.js Community Meetup
Add Berlin.JS to Berlin Code Of Conduct
Added macoun.de to the list of conferences
Hamburg React Meetup
I just noticed that titles are all caps, so I did spacing in the names of our projects:)
Add serverless Hamburg Usergroup
TartanLlama and others added 22 commits October 10, 2017 14:41
Add contacts to React Day Berlin section
feat(add meetup): add SinnerSchrader Hamburg meetup
Add PyLight Meetup to supporters.json
…mmons-license-link

Added link to Creative commons license reference in spanish version
Add the Malmö.rb user group as Supporters
{
"name": "Ekaterina Klykova",
"email": "[email protected]"
"phone": "+493092105978"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several parsing errors in the JSON files. You can see the red markers here on Github. Please fix first. Thanks :)

{
"name": "Paul Berschick",
"email": "[email protected]"
"phone": "+493092105977"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please use one space after the colon for the beauty of it :)

"phone": "+493092105977"
},
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON does not allow a comma here (and other places).

@tthePB
Copy link
Author

tthePB commented Feb 26, 2018

Made all changes – hope everything works now. I'm something of a beginner, so thanks for the feedback, @hagenburger :)

Copy link
Member

@hagenburger hagenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tthePB, we’re open for beginners and invite everybody to contribute and learn :) I added some more comments, please have a look.

Before you submit, you could check the syntax in the Terminal by parsing it either with Node:

node -e "const fs = require('fs'); console.log(JSON.parse(fs.readFileSync('data/supporters.json')))"

or with Ruby:

ruby -e "require 'json'; puts JSON.parse(File.read('data/supporters.json'))"

Both will either output the JSON (but compressed) or raise an error.

"email": "[email protected]",
"phone": "+49 3092105978"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the curly braces below each other for the beauty of it:

       },
       {

"name": "Paul Berschick",
"email": "[email protected]",
"phone": "+49 3092105977"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add a comma, when another opening { is following. The last item in JSON must not have a comma (in JavaScript this would be allowed though).

"name": "Paul Berschick",
"email": "[email protected]",
"phone": "+49 3092105977"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

"email": "[email protected]",
"phone": "+49 3092105978"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

},
]
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@hagenburger
Copy link
Member

Hey @tthePB, is there anything I can do for you with this pull request? Let me know if you have any questions!

@tthePB
Copy link
Author

tthePB commented May 29, 2018

Thanks @hagenburger, I just had no capacity in the last weeks. Will have a look at the comments you gave soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.