Support offenses with no location #123
Merged
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massongit
reviewed
Sep 18, 2024
javierjulio
reviewed
Sep 19, 2024
pcallewaert
force-pushed
the
fix/support-no-line-offenses
branch
from
70d28b9
to
7a09a37
Compare
|
The test should be fixed now :) |
|
Hi, @pcallewaert! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
|
🚀 [bumpr] Bumped! New version:v2.19.1 Changes:v2.19.0...v2.19.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed 2 rubocop offenses were ignored by reviewdog in our code:
These were skipped because they have no location. This meant our pull requests were green but we had some rubocop offenses if we did a full scan on the main branch.
This PR changes the behaviour by not skipping the whole offense, but only the
rangedata.