Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to search the Args to find jobs #714

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bmo
Copy link

@bmo bmo commented Jul 1, 2021

No description provided.

Copy link
Contributor

@iloveitaly iloveitaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this idea! Couple changes we need to make:

  • Could you rebase on master and make sure CI is passing?
  • Could you add a test to cover this new functionality?
  • Could you add a line or two to the readme explaining this funcitonality?
  • Could you add a line to the changelog?

@@ -135,7 +135,7 @@ def self.queue
Resque.enqueue_at(@t, Foo::Bar, 'foo', 'bar')
get(
URI('/delayed/jobs/Foo::Bar?args=' <<
URI.encode(%w(foo bar).to_json)).to_s
URI.encode_www_form_component(%w(foo bar).to_json)).to_s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed on a PR merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants