Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for queueing ActiveJob jobs #696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josh-m-sharpe
Copy link

This allows resque scheduler to set the queue correctly for ActiveJobs when resque schedule's YAML configuration does not set the queue. Depends on this resque PR: resque/resque#1713

Copy link
Contributor

@iloveitaly iloveitaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome addition. Could you make a couple quick tweaks:

  • Add this to the changelog
  • Rebase on master and ensure CI runs
  • Quick documentation change requested

@@ -276,6 +276,8 @@ def enqueue_from_config(job_config)
# CustomJobClass). Otherwise, pass off to Resque.
if klass.respond_to?(:scheduled)
klass.scheduled(queue, klass_name, *params)
elsif klass.respond_to?(:perform_later)
klass.set(queue: queue).perform_later(*params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a one-line comment here about what is code is doing? Even just linking to this PR would be helpful for the future reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants