Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_token option for params #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

grissman
Copy link

A private API I'm working with requires that the request body be sent as a query string in the url. It's possible that others have encountered the same problem. I allow for this option in this pull request.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 87.318% when pulling b3b9bb9 on grissman:master into f8e741d on requests:master.

@sargun
Copy link

sargun commented Nov 23, 2018

Any reason this hasn't been merged?

@meyer1994
Copy link

Monthly reminder to check on this!

@singingwolfboy
Copy link
Member

There's a lot of duplicated code in this pull request, and it doesn't have any automated tests to cover the new functionality. Can you fix those problems? I'm happy to help, if you're not sure how.

@AdamGold
Copy link
Contributor

Since this hasn't been updated in a while, thought I'd chime in. #361

@grissman
Copy link
Author

Thank you @AdamGold! I was just getting back to this, but looks like you already got it done.

@singingwolfboy
Copy link
Member

I've tried to pull the actual code changes out into a separate pull request: #369. Could you please review that, and tell me if it solves your problem?

@charmingduchess
Copy link

Since #369 has been merged, can we close this? it appears from the PR's page that this issue was never resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants