-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: VMSplice/STDOUT consumer #148
base: main
Are you sure you want to change the base?
Conversation
@technillogue see if this works for you, we should generally order the requests for slices. io.copy also handles backpressure from full pipes elegantly (AFAICT). We also do have a greedy reader to capture wire data even if the consumer is blocking. |
d3405db
to
0915e49
Compare
@@ -19,7 +19,7 @@ builds: | |||
archives: | |||
- format: binary | |||
name_template: >- | |||
{{ .ProjectName }}_{{ title .Os }}_ | |||
{{ .ProjectName }}_{{ tolower .Os }}_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ .ProjectName }}_{{ tolower .Os }}_ | |
{{ .ProjectName }}_{{ title .Os }}_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not an intended change.
this could definitely work! would it work with multifile and writing multiple files to stdout in order? |
We can make that happen! Wouldn't be too hard. This was a first pass to see if it looked good. |
It turns out the only reason we don't order downloads which causes you the problem is a historical reason for using a map instead of a list. Additionally there is the maximum concurrent files option already that could limit concurrency -- additionally we can set it to automatically use a max file concurrency of one for stdout/vmsplice modes. |
how would I invoke this? (edit: |
0915e49
to
7e83587
Compare
@technillogue Rebased. Download order is now guaranteed. You will want to make sure to use Please let me know if this works. if so we can easily spin up this output consumer. |
3671e7e
to
1a95670
Compare
this doesn't build
|
No description provided.