Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code-block linenumbers highlight on Safari #1489

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

asikeero
Copy link

Issue

When using Safari and highlighting text in a code block with line numbers, the line numbers are also included. Line numbers are not included with eg. Firefox.

How to reproduce

Open https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/demo.html#emphasized-lines-with-line-numbers with Safari (I used v16.5.2) and highlight the code block.
image

Expected behavior

Line numbers should not be included when highlighting.

What is done

@asikeero asikeero requested a review from a team as a code owner July 19, 2023 14:23
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We're in the middle of a light code freeze while we get some releases out strictly focusing on dependency trimming. This can be planned for version 2.1 or later though.

src/sass/_theme_rst.sass Outdated Show resolved Hide resolved
@agjohnson agjohnson added this to the 2.1 milestone Aug 31, 2023
@asikeero
Copy link
Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants