submit swagkeys sk60 #24373
Open
submit swagkeys sk60 #24373
+233
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submit sk60
|
As per the PR Checklist:
And a couple other things that stood out from looking at your code
|
drashna
reviewed
Sep 9, 2024
keyboards/czmao/ds17/keyboard.json
Outdated
| "knight": true, | ||
| "christmas": true, | ||
| "static_gradient": true, | ||
| "rgb_test": true, |
There was a problem hiding this comment.
You sure you want this enabledd?
drashna
requested changes
Sep 9, 2024
| }, | ||
| "layouts": { | ||
| "LAYOUT": { | ||
| "layout": [ |
There was a problem hiding this comment.
This, and the keymap.c should be reformatted to match the numpad_5x4 layout, since it matches.
And community layout enabled
| @@ -0,0 +1,6 @@ | |||
| # mao ds 17 | |||
There was a problem hiding this comment.
Please re-add full readme, and make sure to include a link to where the hardware can be acquired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist