Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new error code: TRIO912 unnecessary checkpoints + autofix #183

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Apr 28, 2023

fixes #70 (merely 5 months after it was opened 😁)

Early WIP, I only got the basic case down.
I started on this before #182, but I'm prioritizing that one.

Remaining TODO:

  • if statements
    • this shouldn't be that complicated, I've mostly got the logic figured out.
  • loops
    • once if is solved this can probably use similar logic, but it'll likely be messy
  • try/except
    • same

@jakkdl
Copy link
Member Author

jakkdl commented Apr 12, 2024

I picked this up and worked on it somewhat recently, but stalled out due to the complexity. The complexity is mostly because it's hard to resist solving the juicy edge cases and autofixing everything, so next time I pick this up I'll just drop the complex parts, see if the basic cases that are working are worth having as a rule, and clean up the PR so it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASYNC912: Warn on unnecessary checkpoints added to avoid ASYNC910/911
1 participant