Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build config settings to core #715

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

earonesty
Copy link

@earonesty earonesty commented Mar 27, 2024

The build() function takes optional config-settings which can be useful for building gpu-specific packages, editable-mode settings for setuptools, or other build-tool specific configurations. If used, should resolve a number of issues. For example: python-poetry/poetry#8909

(Sorry for the million commits, im editing this in a browser.)

See: https://build.pypa.io/en/stable/api.html. Typing matches that.

If there's no objections, will finish adding tests, etc.

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@radoering
Copy link
Member

If there's no objections, will finish adding tests, etc.

I think, we are open for this setting. Please also create a downstream (draft) PR that shows the usage of this setting. (You can replace the poetry-core dependency with a git dependency pointing to your branch in a temporary commit that will be dropped before merging.)

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, this setting is relevant for all types of dependencies because it's not just relevant for directories but also for sdists?

@earonesty
Copy link
Author

earonesty commented Apr 1, 2024 via email

@igor-sadchenko
Copy link

Hello @earonesty
Any updates here?
Maybe do you need help with this PR?

@earonesty
Copy link
Author

earonesty commented Jun 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants