Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump redis version from <5 to <6 #460

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

Wh1isper
Copy link
Contributor

@Wh1isper Wh1isper commented May 19, 2024

closes #458

Just tried to bump redis from <5 to <6, and CI tests passed.

redis 5 introduced some of incompatible API(aclose and close...) that made it difficult for users to change their code based on version 5, so I think bringing the version up to date it necessary.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (94cd878) to head (af9b484).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   96.27%   96.47%   +0.19%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1040       +6     
  Misses         19       19              
+ Partials       21       19       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1315583...af9b484. Read the comment docs.

@Wh1isper Wh1isper changed the title Update pyproject.toml Bump redis version from <5 to <6 May 19, 2024
@Wh1isper
Copy link
Contributor Author

Wh1isper commented May 19, 2024

May related with: #418

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   96.27%   96.01%   -0.27%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1035       +1     
- Misses         19       21       +2     
- Partials       21       22       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f865a6...294939d. Read the comment docs.

@dbrucknr
Copy link

Is there any update on when this work might be considered for release?

@vprud
Copy link

vprud commented Aug 23, 2024

When are you planning to release with dependency updates?

@RB387
Copy link

RB387 commented Aug 29, 2024

@chrisguidry @samuelcolvin 🙏
This is very important PR. Redis v5 is a significant blocker

Copy link
Contributor

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samuelcolvin samuelcolvin merged commit 0332850 into python-arq:main Aug 29, 2024
11 checks passed
@samuelcolvin
Copy link
Member

Thanks so much.

@samuelcolvin
Copy link
Member

Sorry for the delay in getting back to this 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for redis > 5.0.x in pyproject.toml?
7 participants