Update screenshots on docs intro page #419
Conversation
ChristopherGS
changed the title
docs/index.md
Outdated
| @@ -225,9 +225,13 @@ and it'll end up as structured data in our platform ready to be queried. | |||
| For example, using data from the `User` model above, we could list users from the USA: | |||
|
|
|||
| ```sql | |||
| SELECT attributes->'result'->>'name' as name, age(attributes->'result'->>'dob') as age | |||
| SELECT | |||
There was a problem hiding this comment.
when I ran this query, I got this error:
So I updated with a query that does work
There was a problem hiding this comment.
I personally significantly prefer the original example. I suggest:
SELECT attributes->'result'->>'name' as name, extract(year from (attributes->'result'->>'dob')::date) as "birth year"
FROM records
WHERE attributes->'result'->>'country_code' = 'USA'to demonstrate some fancy-looking SQL. Calculating the age would be better, but apparently datafusion doesn't support extracting years from durations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9696 9696
Branches 1266 1266
=========================================
Hits 9696 9696 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
8ef5dbb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://853e1490.logfire-docs.pages.dev |
| Branch Preview URL: | https://cs-update-docs-for-ga-1.logfire-docs.pages.dev |
.gitignore
Outdated
|
|
||
| # intellij | ||
| .idea |
There was a problem hiding this comment.
I prefer for ppl to use their own global .gitignore on IDE specific files.
| # intellij | |
| .idea |
There was a problem hiding this comment.
What's the harm? Does .gitignore need to be clean?
There was a problem hiding this comment.
I wouldn't accept this on the projects I maintain cause it opens space for ppl to keep adding stuff. I prefer correctness. The gitignore for a project should only contain what is generated from the project itself but shouldn't be committed.
|
It's not important, but I think future screenshots should probably have a profile pic in them. |
There was a problem hiding this comment.
The mixture of with and without service names doesn't look very good on the left, nor does unknown_service on the right (although other people probably wouldn't notice that bit). It'd also be nice if the service names weren't truncated to example-s... and example-a.... How about just api and worker?
|
Also it'd be nice if "Find the needle in a stacktrace" had a screenshot with an actual stacktrace/traceback. |
Updated screenshots to show new UI and removed Beta button