setup: Only require configparser when native version unavailable #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtojnar
force-pushed
the
setup.py-conditional-configparser
branch
from
12ad058
to
9f6bdf3
Compare
On Python 3, configparser library is part of standard library. The configparser package therefore is not needed. For this reason, distributions such as Arch Linux do not even provide this package for Python 3, which in turn breaks the build. This patch changes the setup.py to only add the configparser dependency when native configparser is not available.
jtojnar
force-pushed
the
setup.py-conditional-configparser
branch
from
9f6bdf3
to
05f1836
Compare
Codecov Report
@@ Coverage Diff @@
## develop #232 +/- ##
========================================
Coverage 96.25% 96.25%
========================================
Files 9 9
Lines 934 934
Branches 141 141
========================================
Hits 899 899
Misses 13 13
Partials 22 22Continue to review full report at Codecov.
|
|
Apparently, it is possible to declare version-specific constraints: https://github.com/joke2k/faker/blob/f81cd517e35d72edbdb264d0ec6a0f93f8d37ab8/setup.py#L68-L78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3, configparser library is part of standard library. The configparser package therefore is not needed. For this reason, distributions such as Arch Linux do not even provide this package for Python 3, which in turn breaks the build.
This patch changes the setup.py to only add the configparser dependency when native configparser is not available.