Support hovertemplate on hoveron: fills #6121
Conversation
Scatter trace currently doesn't hovertemplate on hoveron: fills. Change this to allow hovertemplate on fills when mode=='lines'
archmoj
added
status: reviewable
community
| @@ -76,7 +76,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout | |||
| dfltHoverOn.push('fills'); | |||
| } | |||
| coerce('hoveron', dfltHoverOn.join('+') || 'points'); | |||
| if(traceOut.hoveron !== 'fills') coerce('hovertemplate'); | |||
| coerce('hovertemplate', false); | |||
There was a problem hiding this comment.
We could oossibly use
| coerce('hovertemplate', false); | |
| coerce('hovertemplate'); |
so that hovertemplate defaults to blank string.
There was a problem hiding this comment.
Could we keep the initial if statement and just add a condition for lines mode?
if(traceOut.hoveron !== 'fills' || traceOut.mode === 'lines') coerce('hovertemplate');
|
@fredricj Are you interested in completing this PR? |
|
We are using this feature on our site so getting it in would be great. I did for some reason miss the additional comments you made, but there is also some other issue I discovered when creating tests which I didn't have time to resolve. Right now I don't remember what so I will need to revisit the changes again and see what it was. |
|
@fredricj FYI - I added this PR to our |
Scatter trace currently doesn't hovertemplate on hoveron: fills. Change this to allow hovertemplate on fills when mode=='lines'