Add missing for-attribute #6249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
Gomez
changed the title
|
@plone/volto-accessibility Needs review |
Gomez
force-pushed
the
improve-checkbox-a11y
branch
from
146e718
to
4936689
Compare
stevepiercy
requested changes
Aug 12, 2024
|
The failing changelog check is a lie, and can be ignored. See #6232. The failing tests, however, cannot be ignored and must pass. I restarted them in case it was flaky and temporary. |
erral
approved these changes
Aug 14, 2024
ichim-david
reviewed
Aug 14, 2024
packages/volto/src/components/manage/Blocks/Search/components/SearchInput.jsx
Outdated
Show resolved
Hide resolved
ichim-david
requested changes
Aug 14, 2024
There was a problem hiding this comment.
@Gomez have a look at my issue https://github.com/plone/volto/pull/6249/files#r1716735124
Gomez
force-pushed
the
improve-checkbox-a11y
branch
from
4936689
to
85f08bc
Compare
|
Thanks @ichim-david! This is a useful comment, i removed the duplication. Changelog updated with @stevepiercy comments. |
stevepiercy
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Changelog is good. @ichim-david will review upon his return, or someone else can do a technical review.
Gomez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an a11y audit, these improvements were noted.