IE Bug fix - changed slide width from % to px #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Top stuff here! Let me review and merge at some point next week please. Thanks for amazing contribution! |
brabli
added a commit
to brabli/siema
that referenced
this pull request
Nov 7, 2021
brabli
added a commit
to brabli/siema
that referenced
this pull request
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 and Edge round percentages to fewer decimal places than other browsers, and when there are more than a handful of slides, the slides start to offset and bleed into their neighboring slides. This can be seen in Edge at https://codepen.io/adamlyon/pen/JaEqdv , which is a fork for the basic example with just more slides added. As you navigate forward, you can see the next slide peeking from the right side, and gets progressively worse as you get further into the slideshow.
This fix is simply to make the slide width a pixel width instead of a calculated percentage, which works on all browsers. This doesn't need to be a complicated calculation, as the slide size is static (and already known).
Example of working fix: https://codepen.io/adamlyon/pen/yxgGje