Add support for custom matcher functions #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds the ability to specify any function (or set of functions) that provide custom matching behaviour by using a new `custom_matchers` option.
Geekfish
commented
Sep 13, 2019
| defp always_map(headers) do | ||
| # When a request is first recorded then the request headers are stored | ||
| # as a List, but when it's fetched from storage then they are a Map... | ||
| if(is_list(headers), do: Enum.into(headers, %{}), else: headers) |
There was a problem hiding this comment.
I'm not sure if I missed something with this, but maybe on a different issue we can make this consistent (either a List or a Map).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This changeset adds the ability to specify any function (or set of functions)
that provide custom matching behaviour by using a new
custom_matchersoption.As demonstrated in the example provided in the README.md and tests, this should allow to resolve issues like #134 where more specific matching logic is for whatever reason required.
This also opens the possibility of a bigger refactor, where even the "default" matchers (url, method, headers, body etc) are simply functions that are applied in the same way, and users can decide which ones to use or not (removing the need for the
match_requests_onoption).