Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-1038: Fixes #1697, terminus whoami no longer exits with 1 #1926

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Jan 11, 2019

The annotated command library really wants to print '[error]' when the exit code is non-zero, for consistency. If that is okay, then the fix is trivial, as shown.

If the desire is to maintain a '[notice]' and still have the exit code be non-zero, then a modification to the annotated command library would be necessary. We could simply omit the '[error]' output when the message is empty. Consistency is probably better, though; it might be odd to have the command appear to finish successfully, but still set a non-zero exit code.

@greg-1-anderson
Copy link
Member Author

The tests need updating here. Is [error] an acceptable output for users who are not logged in, @TeslaDethray ?

@TeslaDethray
Copy link
Contributor

@greg-1-anderson No, not being logged in is not an erroneous state.

@greg-1-anderson
Copy link
Member Author

OK we'll allow for non-erroneous, non-status-0 exits in the upstream then.

Copy link
Contributor

@TeslaDethray TeslaDethray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants