Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sctp: support sctp data channel #3494

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

johzzy
Copy link
Contributor

@johzzy johzzy commented Mar 31, 2023

support sctp data channel, add page /players/rtc_datachannel.html

@johzzy johzzy force-pushed the feature/sctp branch 2 times, most recently from 9bf0870 to 162cb17 Compare April 2, 2023 13:31
Copy link
Member

@duiniuluantanqin duiniuluantanqin Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to https://github.com/ossrs/srs-sctp/commit/d84928a7f9065114400b0c93980fd0f6900d9dc9, fuzzer and programs do not need to be uploaded.

TRANS_BY_GPT3

Copy link
Contributor Author

@johzzy johzzy Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

TRANS_BY_GPT3

)
fi
# check status
ret=$?; if [[ $ret -ne 0 ]]; then echo "Build usrsctp failed, ret=$ret"; exit $ret; fi
Copy link
Member

@duiniuluantanqin duiniuluantanqin Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If libtool is not installed, it will fail. You should add a prompt to guide the user to install it. For example,

if [[ $ret -ne 0 ]]; then
      Build usrsctp failed, ret=$ret"; 
      if [[ $OS_IS_CENTOS == YES ]]; then
          echo "Please install libtool by:"
          echo "  yum install -y libtool"
      elif [[ $OS_IS_UBUNTU == YES ]]; then
          echo "Please install libtool by:"
          echo "  apt install -y libtool"
      fi
      exit $ret; 
  fi

TRANS_BY_GPT3

Copy link
Contributor Author

@johzzy johzzy Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充了" translates to "supplemented" in English.

TRANS_BY_GPT3

@johzzy johzzy force-pushed the feature/sctp branch 2 times, most recently from a506bab to 4a55287 Compare April 4, 2023 00:56
Copy link
Member

@duiniuluantanqin duiniuluantanqin Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SrsGoApiRtcPublish::check_remote_sdp also needs to support application, right?

TRANS_BY_GPT3

Copy link
Member

@duiniuluantanqin duiniuluantanqin Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rtc/v1/data/ can be considered for deletion. Because application, video, and audio may be generated simultaneously, a single SDP exchange is sufficient. The rtc/v1/publish and rtc/v1/play interfaces can be reused.

TRANS_BY_GPT3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants