zerotier: update to 1.14.1 #24990
Open
zerotier: update to 1.14.1 #24990
+22
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarning
changed the title
Signed-off-by: Moritz Warning <[email protected]>
mwarning
changed the title
|
@ogarcia please have a look. |
ogarcia
reviewed
Sep 18, 2024
| @@ -41,6 +41,7 @@ start_service() { | |||
|
|
|||
| if [ ${enabled} -eq 0 ]; then | |||
| echo "disabled in /etc/config/zerotier" | |||
| return 1 | |||
There was a problem hiding this comment.
I think the best thing to do here is to simply put a plain return instead of a return 1 (as I had put here), I don't think it is necessary for the startup script to return an error if the user has ZeroTier disabled by configuration.
I see everything correct (only if you want to change |
Signed-off-by: Moritz Warning <[email protected]>
The official name of this public network for testing is Earth. Signed-off-by: Moritz Warning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: ramips/mt76x8, OpenWrt master
Run tested: same as compiled for, tl-wr902ac-v3