CONTRIBUTING.md: remove incorrect info about PKG_VERSION
#24971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation stated that
PKG_VERSION
is the OpenWrt version and therefore includes thePKG_RELEASE
, but this statement was incorrect and has been removed to avoid confusion.Motivation and Context
Recently I have done a test commit 22e430c for netbird package, to write this I see others examples and read:
packages/CONTRIBUTING.md
Lines 200 to 205 in 86ad54b
The confusion is, the user can use
PKG_VERSION
to test the version of program, but at same timePKG_VERSION
includesPKG_RELEASE
and can't be used to test version?Let's see how the contributors write their tests:
packages/utils/yq/test.sh
Line 3 in 86ad54b
packages/net/sscep/test.sh
Line 3 in 86ad54b
packages/net/v2raya/test.sh
Line 3 in 86ad54b
To be sure I dive in a little bit and see this:
packages/.github/workflows/entrypoint.sh
Lines 22 to 24 in 86ad54b