Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iputils: bump to 20240905 #24944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nmeyerhans
Copy link
Contributor

Maintainer: me
Compile tested: x86/master
Run tested: x86/master, basic manual runtime testing

Description:

New upstream release: https://github.com/iputils/iputils/releases/tag/20240905

Comment on lines +15 to +16
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=https://codeload.github.com/iputils/iputils/tar.xz/$(PKG_VERSION)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why it was changed from tar.gz to tar.xz?

cc: @ynezz would be good to have some official statement from OpenWrt core members to know, which one is preferred and why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why it was changed from tar.gz to tar.xz?

A better question would by to ask why one would use gzip when xz is available. I'll point out that even our zlib sources are compressed with xz.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better question would by to ask why one would use gzip when xz is available.

after the recent xz-utils drama, the xz format is being avoided, examples

openwrt/openwrt@bab3ae2
openwrt/openwrt@706f0e3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any cause for that. The xz issues have been resolved, and there's no reason to think it is more of a risk than any other dependency at this point. zstd would be a good alternative, if iputils upstream was publishing releases in that format, but it's not. Switching back to gzip does not make sense at this point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching back to gzip does not make sense at this point.

You mean, like its impossible to remove those changes being introduced in this pull request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfectly possible. It just doesn't make sense. xz is a better compression algorithm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway... codeload does not generate .xz tarballs and CI is failing

@neheb
Copy link
Contributor

neheb commented Sep 16, 2024

Switch to local tarballs instead of code load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants